Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add CSV sink in new streaming engine #19441

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add CSV sink in new streaming engine #19441

wants to merge 1 commit into from
+129 −0

Conversation

coastalwhite
Copy link
Collaborator

Mostly a copy of #19431.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Oct 25, 2024
@orlp
Copy link
Collaborator

orlp commented Oct 25, 2024

Looking at crates/polars-io/src/csv/write/write_impl.rs there is internal parallelism with rayon here. Ideally that happens inside the node with parallel input before linearizing.

@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 78 lines in your changes missing coverage. Please review.

Project coverage is 79.92%. Comparing base (425e251) to head (0e8bcad).

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/io_sinks/csv.rs 0.00% 78 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #19441      +/-   ##
==========================================
- Coverage   79.96%   79.92%   -0.04%     
==========================================
  Files        1534     1535       +1     
  Lines      211030   211108      +78     
  Branches     2444     2444              
==========================================
- Hits       168750   168734      -16     
- Misses      41725    41819      +94     
  Partials      555      555

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coastalwhite @orlp